search

kubernetes-monitoring / kubernetes-mixin

A set of Grafana dashboards and Prometheus alerts for Kubernetes.
Apache License 2.0
2.08k stars 597 forks source link

feat: add suppport for empty cadvisorSelector #944

Open lorenzofelletti opened 2 months ago

lorenzofelletti commented 2 months ago

Add support for cadvisorSelector being empty without the resulting generated queries having invalid syntax like {, label="something"}. That could also be easily extended to support more labels being empty.

povilasv commented 4 days ago

I guess question from my side what is the use case of optional selector? I feel like "job" label is almost mandatory concept in Prometheus, so I'm not sure what are we solving here?