Closed rexagod closed 3 months ago
@rexagod did you update the PR with respect to my comments? I don't see any changes :thinking:
@povilasv Sorry for the delay, I've linked the amends below to make them easier to find.
"Is your feature request related to a problem? Please describe.": https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/956/files#diff-b2c61b52820f561dc45f59a811d5dec6cafcc5bd48f4e1ef060b8709a3337df4R14 (A clear and concise description of the enhancement's targeted problem...
)
"Describe the solution you'd like": Same as above (...and its proposed solution
)
"Describe alternatives you've considered" (optional) https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/956/files#diff-b2c61b52820f561dc45f59a811d5dec6cafcc5bd48f4e1ef060b8709a3337df4R41 (...if you have considered any alternatives or workarounds, please share them here.
)
"Additional context" (optional): https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/956/files#diff-b2c61b52820f561dc45f59a811d5dec6cafcc5bd48f4e1ef060b8709a3337df4R42
Similar reasoning for: https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/955
cc @povilasv