search

kubernetes-monitoring / kubernetes-mixin

A set of Grafana dashboards and Prometheus alerts for Kubernetes.
Apache License 2.0
2.12k stars 596 forks source link

feat: Add join label functionality to alerts #961

Closed adberger closed 1 month ago

adberger commented 4 months ago

This PR intends to get the work of https://github.com/kubernetes-monitoring/kubernetes-mixin/pull/792 merged.
Fixes #791

adberger commented 3 months ago

Anyone could take a look at this?

michel-numan commented 3 months ago

Much needed update!

skl commented 1 month ago

@adberger looks like a whitespace issue caused the lint check to fail

adberger commented 1 month ago

@adberger looks like a whitespace issue caused the lint check to fail

Will fix

adberger commented 1 month ago

@skl I've made the 2 changes, could you take another look?
Also do you prefer rebasing into 1 commit?

skl commented 1 month ago

Yeah, feel free to rebase/squash @adberger, the PRs on this repo seem to be normal merge commits so a single commit makes the history a little easier to follow 👍