[Bug]: KubeAPIErrorBudgetBurn doesn't respect clusterLabel - Githubissues

kubernetes-monitoring / kubernetes-mixin

A set of Grafana dashboards and Prometheus alerts for Kubernetes.

Apache License 2.0

2.12k stars 597 forks source link

[Bug]: KubeAPIErrorBudgetBurn doesn't respect clusterLabel #973

Closed dohnto closed 2 months ago

dohnto commented 2 months ago

What happened?

KubeAPIErrorBudgetBurn doesn't respect clusterLabel:

            alert: 'KubeAPIErrorBudgetBurn',
            expr: |||
              sum(apiserver_request:burnrate%s) > (%.2f * %.5f)
              and
              sum(apiserver_request:burnrate%s) > (%.2f * %.5f)

Alerts might not be calculated correctly if mixins are run in multi-cluster environment.

Please provide any helpful snippets.

No response

What parts of the codebase are affected?

Alerts

I agree to the following terms:

[X] I agree to follow this project's Code of Conduct.
[X] I have filled out all the required information above to the best of my ability.
[X] I have searched the issues of this repository and believe that this is not a duplicate.
[X] I have confirmed this bug exists in the default branch of the repository, as of the latest commit at the time of submission.

skl commented 2 months ago

Thanks for contributing, hopefully #889 resolves this for you!