search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

Rename type Files into File #169

Closed fabriziopandini closed 5 years ago

fabriziopandini commented 5 years ago

/kind bug

What steps did you take and what happened: KubeadmConfig object contains a field Files []Files which I feel a little bit awkward considering that the Files type actually describes a single additional file.

What did you expect to happen: The Files type be renamed into File (singular)

detiber commented 5 years ago

Just wanted to add a note that since this affects the API types, this change could only land with a version targeting a new API version.

ncdc commented 5 years ago

As long as this gets in before we release v1alpha2, we can do this, right?

SataQiu commented 5 years ago

If no one claims it, I'd like to pick it up. Wait a while for new contributors! Feel free to self-assign :)

ncdc commented 5 years ago

Please feel free to take it on

detiber commented 5 years ago

As long as this gets in before we release v1alpha2, we can do this, right?

Correct, just wanted to make it clear that if it didn't make the release it would have to wait for v1alpha3 :)

SataQiu commented 5 years ago

/assign /lifecycle active