✨Check if the Control Plane is initialized before generating JoinConfigurations

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm

Apache License 2.0

62 stars 67 forks source link

✨Check if the Control Plane is initialized before generating JoinConfigurations #190

Closed vincepri closed 5 years ago

vincepri commented 5 years ago

Signed-off-by: Vince Prignano vincepri@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [vincepri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

vincepri commented 5 years ago

/assign @detiber @chuckha

/cc @akutz

detiber commented 5 years ago

Does this resolve https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/issues/125?

detiber commented 5 years ago

/lgtm

detiber commented 5 years ago

/hold

akutz commented 5 years ago

Hi @vincepri,

Why was this PR closed?

vincepri commented 5 years ago

@akutz See https://github.com/kubernetes-sigs/cluster-api/pull/1345

akutz commented 5 years ago

Thanks. Maybe in the future when closing an issue in favor of a different solution, you could possibly add a remark like "closing in favor of ..." or "replacing with ...".