search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

:warning: Switch to 1 secret per certificate #197

Closed ncdc closed 4 years ago

ncdc commented 4 years ago

What this PR does / why we need it: Switch to 1 secret per certificate, instead of a single certificate.

Supersedes & replaces #153

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #135

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [ncdc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ncdc commented 4 years ago

@moshloop wrote in his PR:

I also want to make specifying the etcd,proxy and sa certs optional

Do you all want me to do that here?

chuckha commented 4 years ago

no additional comments just delete more code that the linter is complaining about, run go mod tidy and then lgtm