search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

:warning: Adds encoding field for cloud-init files #204

Closed chuckha closed 4 years ago

chuckha commented 4 years ago

Signed-off-by: Chuck Ha chuckh@vmware.com

What this PR does / why we need it: This PR adds an Encoding type for the cloud init files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Related to #202

/assign @detiber

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [chuckha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chuckha commented 4 years ago

/hold

i want to add at least one test to the cloud init module 😔

chuckha commented 4 years ago

/hold cancel

ready for review.

chuckha commented 4 years ago

/hold

changing constants

chuckha commented 4 years ago

/hold cancel

ncdc commented 4 years ago

/lgtm