search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

🐛 Test and logic fixes #211

Closed chuckha closed 4 years ago

chuckha commented 4 years ago

Signed-off-by: Chuck Ha chuckh@vmware.com

What this PR does / why we need it: Some more test clean ups and the discovery of a bug where the user could not set UnsafeSkipCAVerification even if they wanted to. In addition, this adds error handling for a missed error check.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [chuckha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chuckha commented 4 years ago

/assign @fabriziopandini @detiber

liztio commented 4 years ago

/lgtm