search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

🏃 Adds a test to reconcile kubeadmconfig based on clusters #216

Closed chuckha closed 5 years ago

chuckha commented 5 years ago

Signed-off-by: Chuck Ha chuckh@vmware.com

What this PR does / why we need it: This PR adds a test to ensure that KubeadmConfigs are reconciled when their associated clusters are modified.

Included in this PR are also a few bug fixes for the test helpers. This corrects an erroneous APIVersion (missing group) and adds the forward reference to the machine. It was only adding the backwards owner reference.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Related to #214

/assign @fabriziopandini

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [chuckha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
detiber commented 5 years ago

/lgtm