Closed kashifest closed 4 years ago
Hi @kashifest. Thanks for your PR.
I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/assign @vincepri
/ok-to-test
/approve
if you end up using the switch that's cool, but i'm happy with this as is also!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chuckha, kashifest
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
What this PR does / why we need it: Removes error and waits again if
a) machine does not have any associated cluster b) Machine has associate cluster but it is still non-existent
Which issue(s) this PR fixes (optional, in fixes #(, fixes #, ...) format, will close the issue(s) when PR gets merged):
Fixes #212