kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

MachineWatch is wrong #227

Closed chuckha closed 5 years ago

chuckha commented 5 years ago

/kind bug

What steps did you take and what happened: In the process of going through #214, @mikkosest discovered our machine watch is incorrect. It is using util.MachineInfrastructureRef when it should not be using that but should be checking for BootstrapRef instead.

@mikkoset will be writing a test and a new MapFunc to fix this behavior

Thanks so much!!

/assign @mikkoset /lifecycle active /priority important-soon /milestone v0.1.x

k8s-ci-robot commented 5 years ago

@chuckha: GitHub didn't allow me to assign the following users: mikkoset.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/issues/227): >/kind bug > >**What steps did you take and what happened:** >In the process of going through #214, @mikkosest discovered our machine watch is incorrect. It is using `util.MachineInfrastructureRef` when it should not be using that but should be checking for BootstrapRef instead. > > >@mikkoset will be writing a test and a new MapFunc to fix this behavior > >Thanks so much!! > >/assign @mikkoset >/lifecycle active >/priority important-soon >/milestone v0.1.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mikkosest commented 5 years ago

I will start with this

mikkosest commented 5 years ago

/assign @mikkosest