search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

:sparkles: Add lint to make test command #230

Closed kashifest closed 4 years ago

kashifest commented 4 years ago

What this PR does / why we need it: Adds lint test to make test command

k8s-ci-robot commented 4 years ago

Hi @kashifest. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kashifest commented 4 years ago

/assign @chuckha

chuckha commented 4 years ago

an improvement for developers for sure

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [chuckha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vincepri commented 4 years ago

Pinging @ncdc, which IIRC has some thoughts around adding more pre-reqs to make targets

chuckha commented 4 years ago

Yes, I've got lots of thoughts too, but we should put them down in an issue first. I don't think this PR is the place to discuss broader improvements. I don't want to block this PR on us figuring out how to clean up the makefile vs hack/verify scripts problem.

ncdc commented 4 years ago

/lgtm