search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

Add a test for patch behavior #243

Closed chuckha closed 4 years ago

chuckha commented 4 years ago

/kind feature

Describe the solution you'd like There should be a test that tests the behavior of saving an object.

The expected behavior is that if there is an error in reconcile at any point no Patch will be issued.

If there is no error in Reconcile, then a Patch will be issued.

Anything else you would like to add: This is something of a tricky test which is why I've not marked it as good first issue. If you really like testing it might be an ok first issue.

/priority important-soon /milestone v0.1.x

SataQiu commented 4 years ago

/cc

SataQiu commented 4 years ago

/assign /lifecycle active