search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

🏃Add release notes utility / update controller-tools & CRDs #256

Closed vincepri closed 4 years ago

vincepri commented 4 years ago

Signed-off-by: Vince Prignano vincepri@vmware.com

What this PR does / why we need it: This PR adds the make release-notes target

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [vincepri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chuckha commented 4 years ago

oh boy, the tools controller-runtime is different than the actual controller-runtime version 🙃

they should be kept in sync

detiber commented 4 years ago

/lgtm /hold holding for @chuckha

chuckha commented 4 years ago

/hold cancel