search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

🏃Align Makefile with other CAP* repos #257

Closed vincepri closed 5 years ago

vincepri commented 5 years ago

Signed-off-by: Vince Prignano vincepri@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [vincepri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vincepri commented 5 years ago

/hold

until #256 merges

chuckha commented 5 years ago

/lgtm

vincepri commented 5 years ago

/hold cancel

detiber commented 5 years ago

/lgtm

chuckha commented 5 years ago

/hold

looks like fmt and vet snuck back in but they are still deleted?

chuckha commented 5 years ago

/hold cancel /lgtm