search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

fix: ensure there's a token to refresh #267

Closed sethp-nr closed 5 years ago

sethp-nr commented 5 years ago

For init configurations or non-BootstrapToken discovery mechanisms, we shouldn't be trying to refresh tokens.

What this PR does / why we need it:

Fixes a panic reconciling kubeadm configs for a control plane init before the control plane is marked as "ready"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #266

detiber commented 5 years ago

/lgtm /assign @chuckha

chuckha commented 5 years ago

/approve

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha, sethp-nr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [chuckha] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment