search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

🏃 Add test for KubeadmConfigReconciler_ReturnEarlyIfClusterInfraNotReady #277

Closed ashish-amarnath closed 4 years ago

ashish-amarnath commented 4 years ago

Signed-off-by: Ashish Amarnath ashish.amarnath@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

/assign @chuckha

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashish-amarnath To complete the pull request process, please assign luxas You can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ncdc commented 4 years ago

@ashish-amarnath thanks for this. We're in the process of moving this repo's code into the cluster-api repo. Would it be ok if you held on to this, then opened a new PR against cluster-api after the code has moved? In other words, can I close this pending the repo move?

ashish-amarnath commented 4 years ago

@ncdc I am good w/ that!

ncdc commented 4 years ago

Thanks so much for understanding! The more we merge here, the more we have to remember to copy over to cluster-api.

Please don't lose this code though! Keep an eye on https://github.com/kubernetes-sigs/cluster-api/pull/1483. Once it merges, you can open your PR over there.

/close

k8s-ci-robot commented 4 years ago

@ncdc: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/pull/277#issuecomment-540721900): >Thanks so much for understanding! The more we merge here, the more we have to remember to copy over to cluster-api. > >Please don't lose this code though! Keep an eye on https://github.com/kubernetes-sigs/cluster-api/pull/1483. Once it merges, you can open your PR over there. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.