search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

:running: Update controller runtime, Go 1.12, Cluster API v0.2.5 #279

Closed detiber closed 4 years ago

detiber commented 4 years ago

What this PR does / why we need it:

- Update controller-runtime to v0.3.0
- Update golang used to v1.12.10
- Update cluster-api to v0.2.5
k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [detiber] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chuckha commented 4 years ago

@detiber do you think this needs to go in as a final release to CABPK? i'm inclined to hold off until this repo merges with CAPI

detiber commented 4 years ago

@detiber do you think this needs to go in as a final release to CABPK? i'm inclined to hold off until this repo merges with CAPI

Up to you, I mainly created this because I had already done it for CAPI and CAPA.

chuckha commented 4 years ago

I'm unfamiliar with the changes coming in. As far as i know this isn't fixing any bugs we are experiencing. Because of that I will hold off on this PR but gladly accept after we get the merge into CAPI done

ncdc commented 4 years ago

+1 to deferring until this repo has moved in to cluster-api if that's ok?

ncdc commented 4 years ago

LGTM. @vincepri ?