search

kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

Backport spec.users.passwd should be optional/omitempty #291

Closed vincepri closed 4 years ago

vincepri commented 4 years ago

Relevant v1alpha3 commit: https://github.com/kubernetes-sigs/cluster-api/commit/4c5edd4a9298b2897173bfa1b3904b4cc11f051e

/kind bug /priority critical-urgent /help

k8s-ci-robot commented 4 years ago

@vincepri: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/issues/291): >Relevant v1alpha3 commit: https://github.com/kubernetes-sigs/cluster-api/commit/4c5edd4a9298b2897173bfa1b3904b4cc11f051e > >/kind bug >/priority critical-urgent >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vincepri commented 4 years ago

We should also make sure that other fields marked optional have the omitempty tag properly set

nader-ziada commented 4 years ago

/assign