kubernetes-retired / cluster-api-bootstrap-provider-kubeadm

LEGACY REPO. NEW CODE IS https://github.com/kubernetes-sigs/cluster-api/tree/master/bootstrap/kubeadm
Apache License 2.0
62 stars 67 forks source link

📖 use k8s-staging-ci-images vs kubernetes-ci-images #300

Closed spiffxp closed 2 years ago

spiffxp commented 2 years ago

What this PR does / why we need it:

Document that the default CI images are pulled from gcr.io/k8s-staging-ci-images, not gcr.io/kubernetes-ci-images

This was changed via https://github.com/kubernetes/kubernetes/pull/97087 which landed 2021-01-14

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): n/a

Related:

spiffxp commented 2 years ago

/cc @detiber @vincepri

neolit123 commented 2 years ago

i think this repository is stale and the code now lives under a k-sigs/cluster-api folder. @vincepri @fabriziopandini is time to archive this repository?

vincepri commented 2 years ago

Yes it can be archived.

neolit123 commented 2 years ago

@vincepri i will log an issue in k-sigs/cluster api as there are number of action items here, including test-infra cleanup. EDIT: https://github.com/kubernetes-sigs/cluster-api/issues/5037

@spiffxp i think we can merge this to omit it from the org search (e.g. https://cs.k8s.io/). /lgtm /approve

neolit123 commented 2 years ago

i cannot merge it because i'm not in owners. /assign @vincepri

vincepri commented 2 years ago

/approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, spiffxp, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm/blob/master/OWNERS)~~ [vincepri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment