search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🐛 Fix make release-notes #118

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

When I run make release-notes following https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/developer/releasing.md our make target errors with:

→ make release-notes
cd hack/tools && go build -tags=tools -o bin/release-notes sigs.k8s.io/cluster-api/hack/tools/release
no required module provides package sigs.k8s.io/cluster-api/hack/tools/release; to add it:
        go get sigs.k8s.io/cluster-api/hack/tools/release
make: *** [hack/tools/bin/release-notes] Error 1

It appears this is just outdated and we should use CAPI's Makefile as an example: https://github.com/kubernetes-sigs/cluster-api/blob/master/Makefile#L191-L192

christopherhein commented 3 years ago

/kind bug

christopherhein commented 3 years ago

/help

fenglixa commented 3 years ago

/assign

fenglixa commented 3 years ago

/remove-help