search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

:sparkles: Add foundation tooling and files #13

Closed vincepri closed 3 years ago

vincepri commented 3 years ago

This patchset adds a bunch of basic tools and files needed to start working on the controllers within the cluster api ecosystem. Enables us to speed through the basic chores to generate files, run prow jobs (these still need to be setup at the time of writing), add all the release tooling and automatic image building.

Signed-off-by: Vince Prignano vincepri@vmware.com

vincepri commented 3 years ago

/assign @christopherhein

vincepri commented 3 years ago

Yes, it's in Cluster API itself and it's updated by updating the hash version of the capi hack/tools module in hack/tools/go.mod

christopherhein commented 3 years ago

Perfect, thanks @vincepri should it be loaded at test run or local setup time? Happy to keep it just want to confirm since it's a 2+mb binary in a repo.

/hold for @vincepri to diff another provider

vincepri commented 3 years ago

Oh, missed the .gitignore 😂

christopherhein commented 3 years ago

Oh, missed the .gitignore 😂

That makes sense 👍

vincepri commented 3 years ago

Should be good to go!

christopherhein commented 3 years ago

Awesome, thanks for putting all this base work in @vincepri !

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/OWNERS)~~ [christopherhein,vincepri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vincepri commented 3 years ago

/hold cancel

🎉