kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Correct manifest path since the file name has been changed in previously ccommit #142

Closed vincent-pli closed 3 years ago

vincent-pli commented 3 years ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 3 years ago

Hi @vincent-pli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Fei-Guo commented 3 years ago

/approve /lgtm

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, vincent-pli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [Fei-Guo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
christopherhein commented 3 years ago

Whoops, this is probably going to need more updates to work correctly, because the images aren't published anywhere this manifest will fail to be used for any cluster that you don't run make build-images and thus don't push those images into the kind or minikube cluster, it also requires CAPN which will require the user to do and follow the docs/README.md.

Given this isn't ready how should we handle the updates to this? Should we revert since you should be able to use VC w/o CAPN right now via the old readme, and then once we get #129 and #130 ?

christopherhein commented 3 years ago

@Fei-Guo @vincent-pli ^^^^

Fei-Guo commented 3 years ago

@christopherhein Yes. I think you overwrote the old all_in_one with all_in_one_capi? can you add the old all_in_one back and revert the README to the old all_in_one?

christopherhein commented 3 years ago

Oh shoot, wow. sorry I missed that, yea we can add that manifest back.