search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Change flag names in `main.go` #15

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

To help align the flags in this provider with Kubernetes component standards we should change the flag names https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/main.go#L66-L79 

    fs.StringVar(&metricsAddr, "metrics-bind-address", ":8080",
        "The address the metric endpoint binds to.")

    fs.BoolVar(&enableLeaderElection, "leader-elect", false,
        "Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.")

    fs.DurationVar(&leaderElectionLeaseDuration, "leader-elect-lease-duration", 15*time.Second,
        "Interval at which non-leader candidates will wait to force acquire leadership (duration string)")

    fs.DurationVar(&leaderElectionRenewDeadline, "leader-elect-renew-deadline", 10*time.Second,
        "Duration that the leading controller manager will retry refreshing leadership before giving up (duration string)")

    fs.DurationVar(&leaderElectionRetryPeriod, "leader-elect-retry-period", 2*time.Second,
        "Duration the LeaderElector clients should wait between tries of actions (duration string)")
christopherhein commented 3 years ago

/kind feature

christopherhein commented 3 years ago

/priority important-soon

christopherhein commented 3 years ago

/assign

christopherhein commented 3 years ago

/close

k8s-ci-robot commented 3 years ago

@christopherhein: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/15#issuecomment-730735773): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.