search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

✨ Add certmanager flavor #157

Closed charleszheng44 closed 3 years ago

charleszheng44 commented 3 years ago

What this PR does / why we need it: Use cert-manager to manage the PKI for the NCP components.

charleszheng44 commented 3 years ago

/assign @christopherhein

charleszheng44 commented 3 years ago

Overall looks good but I think we need to set longer expiries on the client certs like the default config.

Just prolong the expiries.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [charleszheng44,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment