search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

✨ Enabled Aggregate API for Virtual Cluster #167

Closed gyliu513 closed 3 years ago

gyliu513 commented 3 years ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/166

@christopherhein @Fei-Guo

This PR only covered VirtualCluster but does not cover nested control plane, will fix nested control plane in another PR.

@wangjsty ^^

christopherhein commented 3 years ago

Did you mean to remove the changes you made in controlplane/nested/component-templates/nested-apiserver/nested-apiserver-statefulset-template.yaml prior?

gyliu513 commented 3 years ago

Did you mean to remove the changes you made in controlplane/nested/component-templates/nested-apiserver/nested-apiserver-statefulset-template.yaml prior?

@christopherhein for now, yes, I want to use this PR for virtual cluster and then create another PR for nested control plane soon, hope it is OK.

christopherhein commented 3 years ago

Sounds good, just wanted to make sure. :+1: /lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, gyliu513

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jinsongo commented 3 years ago

@gyliu513 @christopherhein， One more comment even though the PR was merged. I validated the PR again, looks like it's good, but please use - --requestheader-allowed-names=front-proxy-client to replace the current - --requestheader-allowed-names="". Thanks.

christopherhein commented 3 years ago

@gyliu513 @christopherhein， One more comment even through the PR was merged. I validated the PR again, looks like it's good, but please use - --requestheader-allowed-names=front-proxy-client to replace the current - --requestheader-allowed-names="". Thanks.

Good find, @wangjsty can you make sure an issue is filled and @gyliu513 can you do this as well?

gyliu513 commented 3 years ago

@christopherhein Done at https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/179