Closed vincent-pli closed 3 years ago
Hi @vincent-pli. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
While you are there making changes can we change that log to say super cluster has no tenant control planes, giving up periodic checker: {name}
I'd like to move the name of it out of the main message in case we want to trigger alerts/notifications based on log lines it's easier to parse.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: christopherhein, vincent-pli
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: When
patrols
started and novirtualcluster
, it keep report ignore information(since no virtualcluster available), like this:Some of them do not show which
patrols
it come from and some does, so consist them.