Use front-proxy-client CN for aggregate API

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters

Apache License 2.0

301 stars 67 forks source link

Use front-proxy-client CN for aggregate API #179

Closed gyliu513 closed 3 years ago

gyliu513 commented 3 years ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

--requestheader-allowed-names="" indicates to an extension apiserver that any CN is acceptable. Here we should use CN name front-proxy-client which is more secure.

/cc @chrishenzie @Fei-Guo

christopherhein commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, gyliu513

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment