search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Enabled aggregate API for nested controller #180

Closed gyliu513 closed 3 years ago

gyliu513 commented 3 years ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #166

This is a follow up for https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/166 to fix the issue in nested controller.

/cc @chrishenzie @Fei-Guo

chrishenzie commented 3 years ago

/uncc

I lack context on this part of the codebase. Did you mean to CC @christopherhein ? (included in the linked PR #166)

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, gyliu513

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment