search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Not allow edit virtualcluster for some field #184

Closed jichenjc closed 3 years ago

jichenjc commented 3 years ago

What steps did you take and what happened: [A clear and concise description on how to REPRODUCE the bug.]

What did you expect to happen:

kubectl edit vc vc-sample-23

spec:
  clusterDomain: cluster.local
  clusterVersionName: cv-sample-np23 ===> cv-sample-np24

success

expected: it should fail, we should consider only allow desired field to be updated and block others ..

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

/kind bug [One or more /area label. See https://github.com/kubernetes-sigs/cluster-api-provider-nested/labels?q=area for the list of labels]

jichenjc commented 3 years ago

any thoughts on this? @christopherhein @Fei-Guo comments?

jichenjc commented 3 years ago

/assign

Fei-Guo commented 3 years ago

Yes. In current version, we don't consider vc upgrade through changing the cluster version name and we should add webhook to make this field immutable. We defer the upgrade story for cluster version based provisioning because we will design update worklflow based on CAPN in next step.

christopherhein commented 3 years ago

/close

Closing since this PR was implemented and merged.

k8s-ci-robot commented 3 years ago

@christopherhein: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/184#issuecomment-887880429): >/close > >Closing since this PR was implemented and merged. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.