kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 Update for picking up cluster-api v0.4.0 #191

Closed jinsongo closed 3 years ago

jinsongo commented 3 years ago

What this PR does / why we need it:

Update cluster-api to v0.4.0

util.ManagerDelegatingClientFunc has been removed This function was originally used to generate a delegating client when creating a new manager. Controller Runtime v0.9.x now uses a ClientBuilder in its Options struct and it uses the delegating client by default under the hood, so this can be now removed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/189

k8s-ci-robot commented 3 years ago

Hi @wangjsty. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jinsongo commented 3 years ago

@christopherhein @Fei-Guo @gyliu513

christopherhein commented 3 years ago

/ok-to-test

@wangjsty you've been doing a decent amount of work in this project, to help make feedback a little faster have you started the process to join the Kubernetes org? - https://git.k8s.io/community/community-membership.md#member

I'm sure some of us can help support/lgtm your application.

jinsongo commented 3 years ago

@christopherhein @Fei-Guo How can I run all tests in my local environment?

christopherhein commented 3 years ago

@christopherhein @Fei-Guo How can I run all tests in my local environment?

You can run make test in both the root / of the repo and the /virtualcluster dir

christopherhein commented 3 years ago

/lgtm /approve

thank you for doing this!

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, wangjsty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment