search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

📖add minikube info into dev doc #192

Closed jichenjc closed 3 years ago

jichenjc commented 3 years ago

What this PR does / why we need it:

update doc to include minikube Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

gyliu513 commented 3 years ago

Sorry, last comment, https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/docs/dev-quickstart.md#clean-up also needs updated.

jichenjc commented 3 years ago

Sorry, last comment, https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/docs/dev-quickstart.md#clean-up also needs updated.

sure, updated.

gyliu513 commented 3 years ago

/lgtm

jichenjc commented 3 years ago

It's hard to apply these comments as suggestions but can we make it so that only the command line commands are contained within the backticks for all of these and break minikube vs kind commands into separate ones?

updated, thanks~

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment