kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Remove restart.sh and start.sh in docker file #193

Closed jichenjc closed 3 years ago

jichenjc commented 3 years ago

What this PR does / why we need it:

time to time, my env stuck at download this restart.sh and start.sh those files are used for Tilt and not needed at capi 0.4.0 ,so remove them

further info can refer https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/761

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

jichenjc commented 3 years ago

some error I had:

=> CACHED [builder 5/11] RUN --mount=type=cache,target=/root/.local/share/golang --mount=type=cache,target=/go/pkg/mod go mod download 0.0s => CACHED [builder 6/11] COPY main.go main.go 0.0s => [builder 7/11] COPY api/ api/ 1.0s => [builder 8/11] COPY controllers/ controllers/ 1.5s => [builder 9/11] COPY controlplane/ controlplane/ 1.7s => [builder 10/11] RUN wget --output-document /restart.sh --quiet https://raw.githubusercontent.com/windmilleng/rerun-process-wrapper/master/restart.sh && wget --output-document 84.5s ^CERRO[0098] got 3 SIGTERM/SIGINTs, forcing shutdown

gyliu513 commented 3 years ago

/lgtm

christopherhein commented 3 years ago

/lgtm /approve

I personally am not using tilt for dev, if anyone is they can setup a local dockerfile instead. thanks!

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment