✨ Generate the manifests by calling the kubeadm

[charleszheng44]

What this PR does / why we need it: Generate the ncp manifests using the kubeadm executable

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [charleszheng44] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[jzhoucliqr]

Thanks @charleszheng44 for the effort! I'm trying out this PR, however, the etcd statefulset DNS resolve have some issue so it doesn't come up, not sure if you've seen this?

{"level":"warn","ts":1633452597.3438876,"caller":"netutil/netutil.go:131","msg":"failed to resolve URL Host; returning","url":"https://cluster-s1-etcd-0.cluster-s1-etcd.default.svc:2380","host":"cluster-s1-etcd-0.cluster-s1-etcd.default.svc:2380","retry-interval":1,"error":"lookup cluster-s1-etcd-0.cluster-s1-etcd.default.svc on 10.96.0.10:53: no such host"}

[charleszheng44]

Thanks @charleszheng44 for the effort! I'm trying out this PR, however, the etcd statefulset DNS resolve have some issue so it doesn't come up, not sure if you've seen this?

{"level":"warn","ts":1633452597.3438876,"caller":"netutil/netutil.go:131","msg":"failed to resolve URL Host; returning","url":"https://cluster-s1-etcd-0.cluster-s1-etcd.default.svc:2380","host":"cluster-s1-etcd-0.cluster-s1-etcd.default.svc:2380","retry-interval":1,"error":"lookup cluster-s1-etcd-0.cluster-s1-etcd.default.svc on 10.96.0.10:53: no such host"}

@jzhoucliqr Thanks for finding the bug. I am working on it and will let you know once it is fixed 😃

[jzhoucliqr]

I think the issue is because in statefulset we use component name as service name, which ends with -nestedetcd, but the actual service object name ends with -etcd. https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/216/files#diff-d3d34848bfdf7f6567e793bc968606d1628a0c36a69f141ecb7bf09e90c439c3R164

[charleszheng44]

I think the issue is because in statefulset we use component name as service name, which ends with -nestedetcd, but the actual service object name ends with -etcd. https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/216/files#diff-d3d34848bfdf7f6567e793bc968606d1628a0c36a69f141ecb7bf09e90c439c3R164

That's right 😅 Let me try it out. Thanks

[charleszheng44]

@jzhoucliqr It should work now. Would you try it out?

[jzhoucliqr]

@jzhoucliqr It should work now. Would you try it out?

Thanks. Will try it out.

[jzhoucliqr]

@jzhoucliqr It should work now. Would you try it out?

Thanks. Will try it out.

Changes work fine. Thanks @charleszheng44

[christopherhein]

/lgtm