use namespace as kubeletclient cert cn because vn-agent expects that for kubectl exec

[jzhoucliqr]

What this PR does / why we need it:

for kubectl exec/log/port forward, vn-agent needs to know the namespace in supercluster, currently it assumes the kubelet-client cert that virtual apiserver uses have the CN as the namespace, so add this hack to make it work.

Also removed the flag 'kubelet-certificate-authority' in apiserver args because with that virtual apiserver is trying to validate the cert that vn-agent is using, which will fail because the cert doesn't have the pod IP as SAN.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

[k8s-ci-robot]

Welcome @jzhoucliqr!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-nested 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-nested has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @jzhoucliqr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[Fei-Guo]

@charleszheng44 I think this should work in the current TOT CAPN implementation. Will your work of kcp integration also need to apply the hack?

[christopherhein]

/ok-to-test

[charleszheng44]

@charleszheng44 I think this should work in the current TOT CAPN implementation. Will your work of kcp integration also need to apply the hack?

I have not tried the vn-agent with KCP yet.

[christopherhein]

What do we want/need to do with this PR @jzhoucliqr and @charleszheng44 ?

[christopherhein]

@jzhoucliqr would you be able to still rebase this, sorry for the super long delay but this PR makes sense to me.

[jzhoucliqr]

@jzhoucliqr would you be able to still rebase this, sorry for the super long delay but this PR makes sense to me.

Rebased. Yeah It's a long time. Almost forgot about this.

[christopherhein]

thank you and sorry! @jzhoucliqr

/lgtm /approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, jzhoucliqr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment