kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 Ability to deploy vn-agent as a deployment in control plane namespace #227

Closed christopherhein closed 2 years ago

christopherhein commented 3 years ago

User Story

As an operator I would like to deploy the vn-agent with each control plane for better identity trusting between control plane and the vn-agent.

Detailed Description

For now, the code base needs to have the CN set to the name of the control plane namespaces in order to figure out the name of the tenant control plane to work out the prefixing - this was implemented in vc-manager and then regressed in CAPN with - https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/223 as the fix. This issue is to track how we could deploy the vn-agent 1:1 with the control plane instead of using other identity mechanisms.

Anything else you would like to add:

This will likely change the vn-agent deployment flow to move it out of the scope of the virtualcluster deploy and make it deployed via CAPN's cluster controller.

/kind feature

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

christopherhein commented 2 years ago

/lifecycle frozen

christopherhein commented 2 years ago

/close

k8s-ci-robot commented 2 years ago

@christopherhein: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/227#issuecomment-1082137046): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.