search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Add scaffolding #24

Closed charleszheng44 closed 3 years ago

charleszheng44 commented 3 years ago

This PR adds the scaffolding generated by kubebuilder v3.

christopherhein commented 3 years ago

/assign

christopherhein commented 3 years ago

Fixes #19

christopherhein commented 3 years ago

We're going to need to regenerate this unfortunately and maybe to make this a little easier we should start with this PR only adding in the one type first, maybe NCP as a blank resource then we can add the rest of the types in individual PRs.

Specifically cause these we're generated with the wrong proper boilerplate so the license headers are messed up - https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/hack/boilerplate.go.txt and also the wrong domain and groups. https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/PROJECT#L2 should have been cluster.x-k8s.io and the groups for NCP, NKAS, NCM, NEtcd should all be under the group controlplane https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/24/files#diff-d1fb402f1269ba7396dca9cbd03b44ac055874669bce1d0f239fa2f54ea3584bR6.

christopherhein commented 3 years ago

We also should have these kinds under the v1alpha4 api instead of v1alpha1.

christopherhein commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment