Closed m-messiah closed 2 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Hi @m-messiah. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/lgtm
You'll need an approver from https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS or https://github.com/orgs/kubernetes-sigs/teams/cluster-api-provider-nested-maintainers to add the /approve
'd label!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: christopherhein, m-messiah
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: Syncer non-leader pod could be stuck in CrashLoopBackOff because of /healthz unavailable when LeaderElection does not hit the leader callback.
The PR moves /healthz server, pprof server and /metrics listeners outside of leader election logic, allowing them to be available always.