search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 Add additionalPrinterColumns to VirtualCluster CRD #242

Closed m-messiah closed 2 years ago

m-messiah commented 2 years ago

What this PR does / why we need it:

The current cluster listing is useless:

NAME         AGE
dev          24m
dev2         4s

We should improve CRD to add columns, like:

NAME          AGE     PHASE     CLUSTERVERSION
dev           3m58s   Running   v1-18
dev2          6m55s   Running   v1-19

and with -o wide 

NAME         AGE     PHASE     CLUSTERVERSION   CLUSTERNAMESPACE
dev          0s      Pending   v1-18            kcs-071942-dev
dev2         2m57s   Running   v1-19            kcs-a39dce-dev2

We should probably change https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/Makefile#L114 to output:crd:dir=./config/crd as it do nothing now

k8s-ci-robot commented 2 years ago

Hi @m-messiah. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Fei-Guo commented 2 years ago

/ok-to-test

Fei-Guo commented 2 years ago

Thanks for working on this.

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, m-messiah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [Fei-Guo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment