Closed m-messiah closed 2 years ago
Hi @m-messiah. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Thanks for working on this.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Fei-Guo, m-messiah
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
The current cluster listing is useless:
We should improve CRD to add columns, like:
and with
-o wide
We should probably change https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/Makefile#L114 to
output:crd:dir=./config/crd
as it do nothing now