search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

vc-syncer: set HealthCheckNodePort to zero before sync service to sup… #259

Closed crazywill closed 2 years ago

crazywill commented 2 years ago

…er cluster

What this PR does / why we need it: The current logic for sync service miss setting service.spec.HealthCheckNodePort to zero, which may lead to cause port conflict.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 2 years ago

Hi @crazywill. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: crazywill To complete the pull request process, please assign charleszheng44 after the PR has been reviewed. You can assign the PR to them by writing /assign @charleszheng44 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
crazywill commented 2 years ago

/assign @Fei-Guo

Fei-Guo commented 2 years ago

/lgtm

Fei-Guo commented 2 years ago

/ok-to-test

Fei-Guo commented 2 years ago

/approve