search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Moving api -> apis and setting multigroup: true #26

Closed christopherhein closed 3 years ago

christopherhein commented 3 years ago

Once we have NestedCluster we're going to need to have a multigroup controllers turned on to save a bunch of pain later this moved NCP into apis/controlplanes. This also brings the Dockerfile from a standard kubebuilder project.

Signed-off-by: Chris Hein me@chrishein.com

christopherhein commented 3 years ago

/assign @Fei-Guo @charleszheng44

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/OWNERS)~~ [Fei-Guo,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Fei-Guo commented 3 years ago

@christopherhein Please rebase to resolve the conflict.

christopherhein commented 3 years ago

Thanks @Fei-Guo all updated. Just needs. lgtm

Fei-Guo commented 3 years ago

/lgtm