search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🌱 Switching to golangci-lint via actions #267

Closed christopherhein closed 2 years ago

christopherhein commented 2 years ago

What this PR does / why we need it: It seems golangci-lint in prow has started to act up. I'm hoping moving to the standard way to run this as other projects like CAPI did https://github.com/kubernetes-sigs/cluster-api/pull/4374

christopherhein commented 2 years ago

/test pull-cluster-api-provider-nested-test

weiling61 commented 2 years ago

/lgtm

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, weiling61

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
christopherhein commented 2 years ago

/retest

christopherhein commented 2 years ago

/test pull-cluster-api-provider-nested-test

weiling61 commented 2 years ago

/lgtm