search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Remove deprecated annotation for SVC, it block the installation of etcd #268

Closed vincent-pli closed 2 years ago

vincent-pli commented 2 years ago

What this PR does / why we need it: With the k8s version 1.22+, the etcd cannot install success, since the original annotation is deprecated: service.alpha.kubernetes.io/tolerate-unready-endpoints: "true" That's make the coredns cannot resove the pod(etcd pod) which is not ready.

See the issue: https://github.com/coredns/coredns/issues/5159#issuecomment-1033726643

k8s-ci-robot commented 2 years ago

Hi @vincent-pli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vincent-pli commented 2 years ago

@christopherhein

christopherhein commented 2 years ago

/ok-to-test

christopherhein commented 2 years ago

The builds recently started failing cause of some change in test-infra, so this is likely going to be stuck for a bit while we work out that. I started this work here -https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/267 but stalled out with other work.

I plan to get back to this tomorrow.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, vincent-pli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
christopherhein commented 2 years ago

/retest