search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

🐛 Github Actions goreleaser fixes #270

Closed christopherhein closed 2 years ago

christopherhein commented 2 years ago

What this PR does / why we need it:

Since #267 was merged we hadn't tested golangci-lint w/ GitHub actions, this is attempting to fix the issues with the setup.

christopherhein commented 2 years ago

cc @weiling61

christopherhein commented 2 years ago

cc @Fei-Guo

christopherhein commented 2 years ago

/hold

christopherhein commented 2 years ago

/unhold

Fei-Guo commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo, weiling61

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [Fei-Guo,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment