kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

Virtual Cluster k8s version #271

Closed mkcetinkaya closed 2 years ago

mkcetinkaya commented 2 years ago

Hello,

We succesfully deployed super cluster and virtual clusters. Firstly, thanks for your efforts.

Super cluster version 1.21.9 and Virtual cluster version is 1.16.2. And our expectation was Virtual cluster version also same as super cluster (1.21.9) or something else that we can define decleratively.

So our question is that can we define virtual cluster kubernetes version or every time it will be 1.16.2. If so, is there a way to build new container images for newer k8s versions, because only available api,server has version 1.16.2 in docker hub repository.

Thanks and regards

mkcetinkaya commented 2 years ago

Hi again,

Quick update. We have used upstream kubapi-server and controller-manager images (1.21.X). Successfully created vc. However could not deploy pod, it hangs at pending state and kubernetes default service related to virtual cluster is not being created in super cluster. When we check vc-syncer logs we got below message.

dws.go:65] failed reconcile service default/kubernetes CREATE of cluster default-915f56-vc-2 Service "kubernetes" is invalid: spec.clusterIPs: Invalid value: []string{"10.32.0.1"}: must be empty when clusterIP is empty

When we compare with 1.16 version, there is no "clusterIps" line in 1.16 and in 1.21 version there are below lines in kubernetes service in virtual cluster and I guess error is related to this.

clusterIPs: 10.32.0.1

Could you give us a advice for getting rid of this error?

Thanks and regards.

gyliu513 commented 2 years ago

I had same question before at https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/182 , yes, it will be great if we can support different version of tenant Kubernetes clusters.

gyliu513 commented 2 years ago

@vincent-pli have you ever bump the version of tenant cluster and test? Any suggestions? Thanks!

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

m-messiah commented 2 years ago

Hi! We updated samples in https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/301 1.22.13 is the last version tested, but you could try anything else, as you see, the tenant cluster version is configurable

mkcetinkaya commented 2 years ago

Hello @m-messiah first of all thanks for the update.

We tried same version with your suggested example yaml. Virtual cluster with version 1.22.13 was deployed succesfully. However when we deploy some pods, its state is in pending state and describe pod output is like that

" Warning FailedCreate 11s (x12 over 21s) vc-syncer Error creating: failed to list services from cluster default-35c1d7-vc-22 cache: service is not ready"

And also checked default kubernetes service, it was created in VC but not synced to supercluster as in version 1.19

Were you able to deploy pod to VC with version 1.22.X and any suggestion for us?

Thanks

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/271#issuecomment-1279912204): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.