kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

SuperClusterLabelFilter feature gate is missing root namespaces #275

Closed m-messiah closed 2 years ago

m-messiah commented 2 years ago

What steps did you take and what happened: Enable SuperClusterLabelFilter and SuperClusterLabelling features in syncer. Create and delete virtual cluster. Virtualcluster root namespace left in the supercluster forever (and eats resources with control-plane).

What did you expect to happen: The super cluster has no leftovers, its state is the same as before virtualclusters.

Anything else you would like to add: SuperClusterLabelling feature exists in syncer code only, while the root namespace is created in manager native provisioner.

We should label it too, as there is no other way to fetch root namespaces from supercluster.

Environment:

/kind bug /kind regression