search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

✨ Use SuperClusterLabelling feature gate for all objects if enabled #279

Closed m-messiah closed 2 years ago

m-messiah commented 2 years ago

What this PR does / why we need it: SuperClusterLabelling was initially created for namespaces, but there are a lot of other objects and controllers created in virtualclusters. The PR adds labeling for all objects too, which could help in the future to use SuperClusterLabelFilter feature gate for any resource. (or even do something like kubectl get pod -A -l tenancy.x-k8s.io/controlled=true to find only tenant pods in the Kubernetes cluster).

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, m-messiah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment