search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

✨ Use SuperClusterLabelFilter feature gate for all objects if enabled #280

Closed m-messiah closed 2 years ago

m-messiah commented 2 years ago

What this PR does / why we need it:

279 introduced labelling for all objects, so this PR adds filtering to all checkers where it is possible.

There are couple checkers (priority class, storage class, persistent volume) that are used for back populating only and have nothing to do with virtual clusters initially, so they still have labels.Everything() selector. All other checkers are used for synchronisation and garbage collecting, so labelling should help to reduce control-plane operations and overall controller memory consumption in clusters, where super-cluster is used outside of nested scope.

Fei-Guo commented 2 years ago

Thanks for working on this. /lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, m-messiah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[virtualcluster/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/OWNERS)~~ [Fei-Guo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment