search

kubernetes-retired / cluster-api-provider-nested

Cluster API Provider for Nested Clusters
Apache License 2.0
301 stars 67 forks source link

✨ Add golangci-lint for virtual cluster project #285

Closed m-messiah closed 2 years ago

m-messiah commented 2 years ago

What this PR does / why we need it: Previously virtualcluster object has no linting and had some static golang problems or readability issues. The PR is intended to enable linting for the directory. As the initial run showed more than 2500 issues the PR consists of many commits for enabling golangci-lint checkers one by one.

Fei-Guo commented 2 years ago

Again, thanks for the awesome improvement. Please fix the conflicts.

m-messiah commented 2 years ago

rebased

Fei-Guo commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo, m-messiah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/OWNERS)~~ [Fei-Guo,christopherhein] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment